[commit: haddock] ghc-7.8: Only warn about missing docs when docs are missing (e1d934d)

git at git.haskell.org git at git.haskell.org
Mon Feb 17 14:09:43 UTC 2014


Repository : ssh://git@git.haskell.org/haddock

On branch  : ghc-7.8
Link       : http://git.haskell.org/haddock.git/commitdiff/e1d934d8c66a0a361bd811c1d7734a6432cc8007

>---------------------------------------------------------------

commit e1d934d8c66a0a361bd811c1d7734a6432cc8007
Author: Mateusz Kowalczyk <fuuzetsu at fuuzetsu.co.uk>
Date:   Thu Feb 13 23:57:16 2014 +0000

    Only warn about missing docs when docs are missing
    
    This fixes the ‘Missing documentation for…’ message for modules with
    100% coverage.
    
    (cherry picked from commit 50d1d18cc70cf6c8ffcf247743cd8af0ff9aae16)


>---------------------------------------------------------------

e1d934d8c66a0a361bd811c1d7734a6432cc8007
 src/Haddock/Interface.hs |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/Haddock/Interface.hs b/src/Haddock/Interface.hs
index 24d4791..60a20fe 100644
--- a/src/Haddock/Interface.hs
+++ b/src/Haddock/Interface.hs
@@ -195,7 +195,8 @@ processModule verbosity modsum flags modMap instIfaceMap = do
                          else n
 
     out verbosity normal coverageMsg
-    when (Flag_PrintMissingDocs `elem` flags && (header || not (null undocumentedExports))) $ do
+    when (Flag_PrintMissingDocs `elem` flags
+          && not (null undocumentedExports && header)) $ do
       out verbosity normal "  Missing documentation for:"
       unless header $ out verbosity normal "    Module header"
       mapM_ (out verbosity normal . ("    " ++)) undocumentedExports



More information about the ghc-commits mailing list