Section name clash checks in PackageDescription/Check.hs

[Johan Tibell]

Hi,

While adding some package checks for the new benchmark section I came up
with some questions regarding section names. I think we need to clarify the
design here.

Which things live in the same namespace? The current checks seems
inconsistent:

* The library (i.e. package name) and executables live in different
namespaces and thus there's no check that executables don't share the
library name.

* The executables and test suites live in the same namespace:

  , check (not (null testsThatAreExes)) $
      PackageBuildImpossible $ "These test sections share names with
executable sections: "
        ++ commaSep testsThatAreExes

* The test suites and the library live in the same namespace:

  , check libNameClash $
      PackageBuildImpossible $
           "The test suite " ++ testName test
        ++ " has the same name as the package."

I think the latter is wrong. I think the executable, test suite, and
benchmark names should live in the same namespace and the package (and thus
library) name should be in a different one. Do you agree? If we all agreed
then I will remove the check for test suites/library name clashes above and
add a check that checks all pairs of executable, test suite, and benchmark
names.

Cheers,
Johan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.haskell.org/pipermail/cabal-devel/attachments/20111012/d4b69e0d/attachment.htm>