[xmonad] 2013-02-09 change to XMonad.Prompt.Shell breaks shell completion

[adam vogt]

Hi,

After a bit of off-list discussion it looks like md143rbh7f's patch is
good. I've pushed it.

Adam


On Thu, Jan 30, 2014 at 9:12 PM, adam vogt <vogt.adam at gmail.com> wrote:

> Hi,
>
> Thanks for investigating. Completions are better for my purposes with your
> proposed change.
>
> I am not sure what is different about Carlos López Camey and Carsten
> Mattner's setups which made that patch "fix" things.
>
> Adam
>
>
> On Thu, Jan 30, 2014 at 3:04 PM, md143rbh7f <md143rbh7f at gmail.com> wrote:
>
>> The following change from 2013-02-09 breaks shell completion for me:
>>     hunk ./XMonad/Prompt/Shell.hs 65
>>     +    commandToComplete _ c = c
>>
>> It seems to be passing the entire string into compgen in order to get the
>> file completions, but it should only pass the last word. I propose
>> reverting this change. Comments are appreciated.
>>
>> (CCing c.lopez at kmels.net, who originally wrote the patch.)
>>
>> _______________________________________________
>> xmonad mailing list
>> xmonad at haskell.org
>> http://www.haskell.org/mailman/listinfo/xmonad
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.haskell.org/pipermail/xmonad/attachments/20140204/6525be98/attachment.html>