[xmonad] [xmonad-contrib] XMonad.Prompt.Pass patch

[ardumont]

Hello,

Here is the latest patch according to remarks.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: new-xmonad-prompt-patch.dpatch
Type: test/x-patch
Size: 24514 bytes
Desc: new-xmonad-prompt-pass.dpatch
URL: <http://www.haskell.org/pipermail/xmonad/attachments/20140829/2fda776a/attachment-0001.bin>
-------------- next part --------------

Below I detail some steps I took.

Hope everything is alright.

Thanks for your time.

ardumont writes:

> Hello,
>
> Daniel Schoepe writes:
>
>> Hi again,
>>
>> I'm very sorry that it took so long for me to respond. The patch looks
>> good now; however it causes a conflict with a change to the cabal file
>> (just some trivial formatting stuff).
>
> No problem.
>
>>
>> The dependency on filepath is fine since it's a library that's shipped
>> with GHC anyway (and xmonad depends on it already), so you can remove
>> that comment on that import statement from the patch.
>
> Ok good to know. I'll remove them then.
>
>>
>> If you resubmit the patch with the comment removed and the conflict
>> resolved, I'll apply it ASAP and I promise it won't take a month this
>> time. :)
>
> Ok, cool.
>
> I just need to adapt the code and amend the patch right?

Actually I did (I am not darcs fluent yet), from XMonadContrib local repository:

- darcs unrecord # only my last patch without touching anything

- darcs revert   # to revert only some part of my last working copy

- darcs pull     # to fetch and apply the new patches

- # undid to take into account what you asked for

- cabal install

- # reload xmonad configuration - https://github.com/ardumont/dot-files/blob/use-xmonad-prompt-pass/.xmonad/xmonad.hs#L183

- # check everything still works as before (it does!)

- darcs record

- darcs send -o new-xmonad-prompt-patch.dpatch

>
>>
>> PS: Could you also provide a more verbose commit message for the
>> patch?
>
> Is it ok for you if I use the documentation description for the commit
> message then?
>

I did that.

> Cheers,
> Antoine
>>
>> Cheers,
>> Daniel
>>
>> On Wed, 23 Jul 2014 11:58 +0200, ardumont wrote:
>>> Hello,
>>>
>>> So I updated the code according to our last exchange.
>>>
>>> Enclosed in this email, you will find the amended patch.
>>>
>>> The documentation has been updated as well:
>>>
>>> #+begin_src doc
>>> This module provides 3 XMonad.Prompt to ease passwords manipulation (generate, read, remove):
>>>
>>>     one to lookup passwords in the password-storage.
>>>     one to generate a password for a given password label that the user inputs.
>>>     one to delete a stored password for a given password label that the user inputs.
>>>
>>> All those prompts benefit from the completion system provided by the module XMonad.Prompt.
>>>
>>> The password store is setuped through an environment variable PASSWORD_STORE_DIR. If this is set, use the content of the variable. Otherwise, the password store is located on user's home $HOME/.password-store.
>>>
>>> Source:
>>>
>>>     The password storage implementation is the password-store cli.
>>>     Inspired from http://babushk.in/posts/combining-xmonad-and-pass.html
>>>
>>> Synopsis
>>> #+end_src
>>>
>>> An insight about I tested this, I modified my xmonad.hs and reloaded xmonad:
>>> - without the environment variable. Pass does look into the
>>> `~/.password-store`. I have completion proposed on the prompt (my
>>> password store is stored there)
>>> - with the environment variable (in xmonad's main function, I added an
>>> ugly `System.Posix.setEnv "PASSWORD_STORE_DIR" "/home/tony" True`. I
>>> have no completion on the prompt because there is nothing there.
>>>
>>> Cheers,
>>>
>>> Daniel Schoepe writes:
>>>
>>>> Hi,
>>>>
>>>> On Tue, 22.07.2014 17:36 +0200, ardumont wrote:
>>>>> I propose to improve the existing code with the first implementation suggestion as
>>>>> a first step.
>>>>>
>>>>> And then, if it is approved and merged, see what users say about it.
>>>>> What do you think?
>>>>
>>>> sounds good to me.
>>>>
>>>> Best regards,
>>>> Daniel
>>>
>>>
>>> --
>>> @ardumont
>
>
> --
> @ardumont

Cheers,

--
@ardumont