[xmonad] Re: darcs patch: X.H.UrgencyHook: performance fix

Gwern Branwen gwern0 at gmail.com
Mon Mar 29 18:53:39 EDT 2010


2010/3/29 Tomáš Janoušek <tomi at nomi.cz>:
> Hello,
>
> On Mon, Mar 29, 2010 at 09:43:57AM -0700, Don Stewart wrote:
>> > Sat Mar 27 21:15:03 CET 2010  Tomas Janousek <tomi at nomi.cz>
>> > +    adjustUrgents (\\ sw') >> adjustReminders (filter $ (not . (`elem` sw') . window))
>>
>> Perhaps use notElem ?
>
> Yes, sure, I totally forgot about that :-). Is it easier if the one who pushes
> that patch just makes another one with this change or shall I post a fixed
> patch? (I'm not that familiar with the usual darcs practices, sorry.)

It's best if you make the change, and then record it using 'darcs
amend-record'; then re-'darcs send' it. This keeps the history clean
with a single push of a single patch for a single change. Darcswatch
is smart enough to know that the old patch is automatically 'obsolete'
and it only should track the new patch made using 'amend-record'.

-- 
gwern


More information about the xmonad mailing list