[xmonad] Re: Issue 388 in xmonad: Google Chrome's dialog changes size back and forth rapidly

[codesite-noreply at google.com]

Comment #5 on issue 388 by wei.hoo: Google Chrome's dialog changes size  
back and forth rapidly
http://code.google.com/p/xmonad/issues/detail?id=388

I completely removed the following code which "fixed" this issue:


Index: chrome/browser/gtk/gtk_util.cc
===========================================================
========
--- chrome/browser/gtk/gtk_util.cc	(revision 44042)
+++ chrome/browser/gtk/gtk_util.cc	(working copy)
@@ -209,18 +209,6 @@

    if (resizable) {
      gtk_window_set_default_size(window, width, height);
-  } else {
-    // For a non-resizable window, GTK tries to snap the window size
-    // to the minimum size around the content.  We still want to set
-    // the *minimum* window size to allow windows with long titles to
-    // be wide enough to display their titles, but if GTK needs to
-    // make the window *wider* due to very wide controls, we should
-    // allow that too.
-    GdkGeometry geometry;
-    geometry.min_width = width;
-    geometry.min_height = height;
-    gtk_window_set_geometry_hints(window, GTK_WIDGET(window),
-                                  &geometry, GDK_HINT_MIN_SIZE);
    }
    gtk_window_set_resizable(window, resizable ? TRUE : FALSE);
  }

Since XMonad doesn't show a title bar anyway, hopefully this change isn't  
going
to break anything. However, I think the proper fix is to make sure the  
maximum
size hint is greater than the minimum size hint.

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings