[xmonad] Move EWMH support initialization to a startupHook

Daniel Schoepe daniel.schoepe at googlemail.com
Thu Oct 22 08:04:09 EDT 2009

On Sat, Oct 10, 2009 at 11:44:51PM -0600, Justin Bogner wrote:
> This patch will break existing configs.
> EwhmDesktops.setSupported sets some X atoms to constants. This should
> rightfully be done once, in a startup hook, rather than repeatedly in
> the log hook. This complicates the user configs a bit (though they can
> just use Config.Desktop) but fixes problems like setWMName having to be
> called in the log hook if ewmh is being used.

> Sat Oct 10 23:35:38 MDT 2009  Justin Bogner <mail at justinbogner.com>
>   * Move EWMH support initialization to a startupHook
>   Set EWMH support atoms and the window manager name in a startup hook,
>   rather than in the log hook: the log hook occurs far too frequently
>   for it to make sense to set constants with it.

I think that the benefits of this patch outweigh the breakage since
the current behavior is somewhat broken in my opinion.

Applied, thanks!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
Url : http://www.haskell.org/pipermail/xmonad/attachments/20091022/36754f68/attachment.bin

More information about the xmonad mailing list