[xmonad] darcs patch: ThreeColMid - Swap slave window positions

[Anders Engström]

You misunderstood the changes I made a bit. All I did was to swap the
positions of the slave panes. Previously they were placed like this |
slave1 | master | slave2 |. Which result in the following order with
three windows present and using W.focusDown: | 2 | 1 | 3 |. I changed
it so it becomes | slave 2 | master | slave1 |, or with W.focusDown |
3 | 1 | 2 |, since we wrap around at the end of the list we will be
moving from the top and moving to the bottom of each column and then
from the left to the right continously. This instead of moving from
the top to the bottom and then from the right to the left.

After sleeping on this I came up with the idea that a vertical and a
horizontal reflect will result in a very similar result, except that
the master window will be at the bottom (and a pixel here and there in
width). But this feels a bit tedious, I would consider this the new
behaviour the expected behaviour. If the proposed changed would be
accepted, the old behaviour could be emulated in the same way and with
the same drawback.

/Anders

On Mon, May 4, 2009 at 01:49, Adam Vogt <vogt.adam at gmail.com> wrote:
> * On Sunday, May 03 2009, Anders Engstrom wrote:
>
>>Sun May  3 21:50:26 CEST 2009  Anders Engstrom <ankaan at gmail.com>
>>  * ThreeColMid - Swap slave window positions
>>  This patch will swap the positions of the two slave windows and this
>>  will result in a more intuitive window order. When using focusDown
>>  beginning in the master pane we will move in the following graphical
>>  order 2->3->1->2->3 instead of 2->1->3->2->1. This is backwards from
>>  what is expected.
>
> So instead of going down the two columns alternating between the two,
> you've changed it to go down a single column at a time?
>
>>  The small drawback is that increasing from 2 to 3 windows (and therefore
>>  also columns) will behave in a less intuitive way. The window in the
>>  right column will jump to the left of the screen.
>
> Perhaps there is a way to avoid this issue and keep your changes to the
> focus behavior: I found ThreeColMid to be quite predictable when I tried it
> a couple weeks ago.
>
> Perhaps you could achieve focusing down a single column with a binding to
> something like:
>
>> windows $ W.focusDown . W.focusDown
>
> Of course with a special case for < 3 windows. Perhaps something like
> PerLayoutKeys would be required for making such configurations more sane.
>
>>  I think that it is a good idea to make this change since I rely a lot on
>>  the window order but people using WindowNavigation may be of a different
>>  opinion.
>
> WindowNavigation users are unaffected by window order, so the only issue
> would be your changing of the behavior when windows are added.
>
>>  An alternative is to add an option to select in what way to behave, but
>>  that could be overkill... I leave it up to discussion and devs to
>>  decide.
>
> I agree about that being overkill.
>
> Adam
>