[xmonad] Enabling -fwarn-tabs for commit test (for contrib)

Spencer Janssen spencerjanssen at gmail.com
Tue Jun 23 23:32:36 EDT 2009


On Tue, Jun 23, 2009 at 11:08:32PM -0400, Adam Vogt wrote:
> Hi,
> 
> I want to add '-fwarn-tabs' to the warnings run when testing patches?  (and 
> clean up the couple uses of tabs).
> 
> The warning is documented in ghc-6.8, missing in ghc-6.6 (but it could still be
> there?), ghc-6.6 does not support the current darcs contrib, due to various 
> pragmas in use, such as -XDeriveDataTypeable, among others.
> 
> Changing the -fglasgow-exts flags to more specific pragmas should carry the 
> same risks too.
> 
> Cheers,
> Adam

I think we were waiting on -fwarn-tabs until we stopped supporting 6.6.  Now
that we've done that we should absolutely activate -fwarn-tabs.

In the case of -fglasgow-exts, do be careful.  I think there were some bugs
between 6.8 and 6.10 and extension flags.


Cheers,
Spencer Janssen


More information about the xmonad mailing list