[xmonad] darcs patch: hide the implementation type in "EwmhDes... (and 1 more)

[Joachim Breitner]

Hi,

Am Donnerstag, den 11.09.2008, 03:48 -0500 schrieb Spencer Janssen:
> On Mon, Sep 08, 2008 at 12:01:35PM +0200, Joachim Breitner wrote:
> > Hi,
> > 
> > I???ve merged this patch, and re-submit it now. Isn???t it nicer to have the
> > exposed type less implementation-specific?
> > 
> > Greetings,
> > Joachim
> > 
> > Tue Jun 10 21:29:18 CEST 2008  Joachim Breitner <mail at joachim-breitner.de>
> >   * hide the implementation type in "EwmhDesktopsLayout"
> >   Instead of exporting the EwmhDesktopsHook type, which is used internally,
> >   export a type alias for (HandleEvent EwmhDesktopsHook), so users don't have
> >   to update their xmonad.hs if the implementation changes.
> >   
> >   It could also be wrapped in a newtype, instead of a "type", but that would
> >   require manual instances of the various classes, as ghc can automatically
> >   derive the LayoutClass instance.
> > 
> > Mon Sep  8 11:59:17 CEST 2008  Joachim Breitner <mail at joachim-breitner.de>
> >   * Merge "hide the implementation type in "EwmhDesktopsLayout""
> 
> Can we get this as a fresh patch?  We try to avoid pushing conflicts because it
> can give darcs a headache.  Also, I think EwmhDesktopsHook should still be
> exported, there is no good reason for it not to be.

Hmm. If EwmhDesktopHook stays exported, then there is no need for this
patch. I’ll just abandon this patch, not that I care a lot about it, as
it’s mostly a stylistic question.

Greetings,
Joachim

-- 
Joachim "nomeata" Breitner
  mail: mail at joachim-breitner.de | ICQ# 74513189 | GPG-Key: 4743206C
  JID: nomeata at joachim-breitner.de | http://www.joachim-breitner.de/
  Debian Developer: nomeata at debian.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: Dies ist ein digital signierter Nachrichtenteil
Url : http://www.haskell.org/pipermail/xmonad/attachments/20080911/0d0ef345/attachment.bin