[Xmonad] patch: StackSet.hs edits
dons at galois.com
Thu Oct 25 11:04:04 EDT 2007
> On Monday 22 October 2007 16:36:25 Brent Yorgey wrote:
> > Hi all,
> > I've begun going through the xmonad code carefully, in order to understand
> > how it works, be able to contribute more, etc. Today I went through
> > StackSet.hs. While I was going through I made a bunch of small changes
> > (mostly documentation changes). The only code changes I made were (1)
> > changing a gratuitous 'return' to 'Just'; (2) renaming 'findIndex' to
> > 'findTag'. The second may be controversial; I don't know what the policy
> > is on changing the names of functions exported by the core, but to me
> > 'findTag' says *much* more clearly what the function does.
> > I have also attached a patch for XMonadContrib which changes findIndex to
> > findTag in the only contrib module which uses it, Dzen.hs. Obviously this
> > patch should only be applied if the corresponding patch for core is made.
> > -Brent
> Don, do you think this should go in?
Yes, and just note that if you use findIndex, your Config.hs will break.
Otherwise, seems good.
More information about the Xmonad