[Xmonad] Full screen float window and its border

[Don Stewart]

sjanssen:
> On Wednesday 10 October 2007 01:07:22 Xiao-Yong Jin wrote:
> > Dear xmonad users,
> >
> > After a recent pull, I found out that the `manageHook' works
> > quite good with gimp, mplayer, acrobat reader and etc.
> > However, the extra borders showing at the top and left when
> > in full screen mode are quite annoying.  I tried to make a
> > change as
> >
> > {
> > hunk ./Operations.hs 535
> > -        rr = W.RationalRect ((fi (wa_x wa) - fi (rect_x sr)) % fi
> > (rect_width sr)) -                            ((fi (wa_y wa) - fi (rect_y
> > sr)) % fi (rect_height sr)) +        rr = W.RationalRect ((fi (wa_x wa -
> > bw) - fi (rect_x sr)) % fi (rect_width sr)) +                           
> > ((fi (wa_y wa - bw) - fi (rect_y sr)) % fi (rect_height sr)) }
> 
> I'm not sure if this is the right fix, I'll have to think about it a bit.
> 
> > which works for acrobat reader.  But mplayer in full screen
> > mode shows extra borders at the right and bottom.  I guess
> > probably I'm looking in a wrong place?
> >
> > BTW, I found a small bug in the code for `adjust' and this
> > should fix it.
> >
> > {
> > hunk ./Operations.hs 59
> > -    let adjust (W.RationalRect x y wid h) | x + wid >= 1 || y + wid >= 1
> > || x <= 0 || y <= 0 +    let adjust (W.RationalRect x y wid h) | x + wid >=
> > 1 || y + h >= 1 || x <= 0 || y <= 0 }
> 
> Nice catch, I've fixed this and a related issue in darcs.

Spencer, can you elaborate on what the issue is here?

-- Don