[Xmonad] RotView readability patch

David Roundy droundy at darcs.net
Thu Oct 11 14:42:37 EDT 2007


On Thu, Oct 11, 2007 at 11:04:48AM -0700, Eric Mertens wrote:
> Hello,
> 
> I started using RotView recently, but I felt like the code was rather
> difficult to understand at a glance. I wanted to share the changes I
> made in case anyone else felt the same way.
> 
> Other than some minor code changes and library function usage issues, I
> did want to say that RotView does exactly what I wanted.
> 
> (This patch should introduce no new behavior.)

I'd say these changes are an improvement, although I think you've got a few
too many variables defined for real clarity.  Removing sortWs would only
improve clarity:

  sorted = sortBy (comparing tag) (hidden ws)

is quite clear.
-- 
David Roundy
Department of Physics
Oregon State University
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://www.haskell.org/pipermail/xmonad/attachments/20071011/d82d0e78/attachment.bin


More information about the Xmonad mailing list