Proposal: add traverseWithKey to Data.Map

Max Bolingbroke batterseapower at hotmail.com
Thu Mar 15 17:22:15 CET 2012


On 15 March 2012 15:47, Thomas Schilling <nominolo at googlemail.com> wrote:
> A few minor comments below.

Thanks for your documentation suggestions. I will certainly
incorporate them into the final patch.

> I think we're moving away from INLINE in favour of INLIN[E]ABLE.  In
> this case it seems fine since it's just building a closure +
> tailcalling which probably would get optimised away.  Still, would
> using INLINEABLE have a drawback in this case?

To my mind, INLINEABLE really serves a different purpose than INLINE:
it doesn't really force GHC to inline something, just expose the
unfolding. We still need to force INLINE for SATed functions in order
to achieve actual function specialisation. I think the other replies
to the list elaborate on this point.

Cheers,
Max



More information about the Libraries mailing list