[Haskell-cafe] Faster timeout but is it correct?

[Johan Tibell]

On Tue, Feb 22, 2011 at 2:46 AM, Bas van Dijk <v.dijk.bas at gmail.com> wrote:
> On 22 February 2011 03:10, Johan Tibell <johan.tibell at gmail.com> wrote:
>> On Mon, Feb 21, 2011 at 3:16 PM, Bas van Dijk <v.dijk.bas at gmail.com> wrote:
>>> On 21 February 2011 21:55, Johan Tibell <johan.tibell at gmail.com> wrote:
>>>> ...include TimeoutKey in the TimeoutCallback type.
>>>
>>> Done: http://hackage.haskell.org/trac/ghc/attachment/ticket/4963/faster_timeout.dpatch
>>
>> Could we store a full TimeoutCallback in the PSQ? At the line that reads
>>
>>      sequence_ $ map Q.value expired
>>
>> you'll need to pass the PSQ key (which is the Unique) to the callback.
>
> Good point. Something like this:
>
> sequence_ $ map (\(Elem key _ cb) -> cb (TK key)) expired

Yes.

> Ok, I will apply it this evening.

Excellent. Thanks for working on this.

Johan