[PATCH 1/2] add calloc and callocBytes to Foreign.Marshal.Alloc

Ian Lynagh igloo at earth.li
Fri Apr 22 17:59:22 CEST 2011


On Fri, Apr 22, 2011 at 07:20:55AM -0700, Jason Dagit wrote:
> 
> That wiki page doesn't say how long the discussion period should be or give
> advice on how to determine the size.  What would you recommend for this
> patch?

I just updated the page to recommend 2 weeks, which I think is the
status quo.

> So it sounds like the things I missed were:
>   * putting "Proposal:" in the subject line
>   * setting a discussion period
>   * attaching my patch to the trac instance (can I send a pull request on
> github instead?)

You don't need to make a trac ticket for it until the proposal has been
accepted.

Anything that means we see that the patch needs to be applied is OK.
Currently pull requests don't get sent to the mailing list though, and
there doesn't seem to be an easy way to set that up.


I also didn't notice a rationale for the change. The type signatures
looked the same as for the malloc functions, so I don't know what the
difference is.


Thanks
Ian




More information about the Libraries mailing list