darcs patch: Adding isLeft, isRight, fromLeft, fromRight, splitEithers

roconnor at theorem.ca roconnor at theorem.ca
Tue Oct 31 11:38:18 EST 2006


On Tue, 31 Oct 2006, Bulat Ziganshin wrote:

> Monday, October 30, 2006, 4:35:45 PM, you wrote:
>
>>   * Adding isLeft, isRight, fromLeft, fromRight, splitEithers
>
> two minor points: first, please add ',' to the end of export list.
> second, isn't "Either.fromLeft: Received Right" should be
> "Either.fromLeft: received Right" - i.e. with lowercased 'received'?
>
> in general, i suggest adding of ',' to the end of export list for all
> patches we does

Okay, when correcting a patch, should I ammend-record it, make a new 
patch, or bundle two dependent patches together?

I'm thinking of separating out the controversial isLeft, isRight, 
fromLeft, and fromRight from this patch, and focus on the less 
contravertial splitEithers.

Actually, I'm starting to like the name unzipEithers, so I propose 
changing this patch to add only unzipEithers, lefts, and rights.  We can 
then consider isLeft, isRight, fromLeft, and fromRight on another thread.

-- 
Russell O'Connor                                      <http://r6.ca/>
``All talk about `theft,''' the general counsel of the American Graphophone
Company wrote, ``is the merest claptrap, for there exists no property in
ideas musical, literary or artistic, except as defined by statute.''


More information about the Libraries mailing list