[GHC] #5818: gcd and fizzled reversed in event SparkCounters
GHC
cvs-ghc at haskell.org
Tue Feb 7 10:17:51 CET 2012
#5818: gcd and fizzled reversed in event SparkCounters
---------------------------------+------------------------------------------
Reporter: MikolajKonarski | Owner: duncan
Type: bug | Status: new
Priority: normal | Milestone: 7.6.1
Component: Runtime System | Version: 7.4.1-rc1
Keywords: | Os: Unknown/Multiple
Architecture: Unknown/Multiple | Failure: Incorrect result at runtime
Difficulty: Unknown | Testcase:
Blockedby: | Blocking:
Related: |
---------------------------------+------------------------------------------
Comment(by MikolajKonarski):
Duncan has chosen the last option. The minimal fix on the ghc-events side
is here:
[https://github.com/Mikolaj/ghc-
events/commit/8f20e9f35d73507355f2c90440f5a367a5dcb0bc]
dcoutts: if you don't mind I'd break the ghc-events API (the utility
facing part, not the GHC facing part) to keep the order of fiz and gcd
consistent across all code
dcoutts: https://github.com/Mikolaj/ghc-
events/commit/ec4dd1311502f52edce721ea1cefa1becc66706e
dcoutts: about a dozen changes are required in TS to adapt to the changed
API
dcoutts: I think it's better to do the changes now when we remember about
the fiz and gcd swap
dcoutts: rather than hunt bugs stemming from the inconsistent order later
on
--
Ticket URL: <http://hackage.haskell.org/trac/ghc/ticket/5818#comment:3>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler
More information about the Glasgow-haskell-bugs
mailing list