[GHC] #4205: Improve Threading Support for FreeBSD

[GHC]

#4205: Improve Threading Support for FreeBSD
---------------------------------+------------------------------------------
    Reporter:  pgj               |        Owner:              
        Type:  feature request   |       Status:  patch       
    Priority:  normal            |    Milestone:              
   Component:  Runtime System    |      Version:  6.13        
    Keywords:                    |   Difficulty:              
          Os:  FreeBSD           |     Testcase:              
Architecture:  Unknown/Multiple  |      Failure:  None/Unknown
---------------------------------+------------------------------------------

Comment(by simonmar):

 Thanks for the patch.  Patch review: approved in principle, but please do
 not add

 {{{
 #define __BSD_VISIBLE   1
 }}}

 to `PosixSource.h`.  The point of `PosixSource.h` is that it labels
 ''portable'' C code; if the C code is not portable then it should not
 `#include "PosixSource.h"` at all (and instead should include a comment
 explaining why it isn't portable).  i.e. move the above `#define` into
 `OSThreads.h`, and put `#ifndef freebsd_HOST_OS` around the `#include
 "PosixSource.h"`.

-- 
Ticket URL: <http://hackage.haskell.org/trac/ghc/ticket/4205#comment:2>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler