[GHC] #4377: sizedText function for Text.PrettyPrint

GHC cvs-ghc at haskell.org
Fri Dec 10 15:32:45 CET 2010


#4377: sizedText function for Text.PrettyPrint
-------------------------------------------------------------------+--------
    Reporter:  lerkok                                              |        Owner:              
        Type:  proposal                                            |       Status:  new         
    Priority:  normal                                              |    Milestone:  Not GHC     
   Component:  libraries/pretty                                    |      Version:              
    Keywords:  text, sizedText, pretty printing, Text.PrettyPrint  |     Testcase:              
   Blockedby:                                                      |   Difficulty:              
          Os:  Unknown/Multiple                                    |     Blocking:              
Architecture:  Unknown/Multiple                                    |      Failure:  None/Unknown
-------------------------------------------------------------------+--------

Comment(by maeder):

 I had a look into the original file to suggest a patch for the above code,
 which misses one documenting haddock sentence and the adjusted export
 list.

 However, the file contains trailing spaces, tabs, too long lines,
 redundant brackets and semicolons, etc.

 Apart from replacing the definition of `zeroWidthText`, also the
 definition of `indent` (and `spaces`) should be replaced by `(`replicate`
 ' ')`; `multi_ch` can be replaced by `replicate`.

 I could create a couple of patches. To whom should I "darcs send" them? Or
 who would commit the changes. I suggest to bump the version to 1.0.2.0,
 since the interface is extended. (The addition of zeroWidthText changed
 the version from 1.0.0.0 to 1.0.1.0, too)

-- 
Ticket URL: <http://hackage.haskell.org/trac/ghc/ticket/4377#comment:5>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler



More information about the Glasgow-haskell-bugs mailing list