[GHC] #2720: eyeball/inline1 still isn't optimised with -fno-method-sharing

[GHC]

#2720: eyeball/inline1 still isn't optimised with -fno-method-sharing
--------------------------------------+-------------------------------------
 Reporter:  rl                        |          Owner:                  
     Type:  run-time performance bug  |         Status:  closed          
 Priority:  normal                    |      Milestone:  6.10 branch     
Component:  Compiler                  |        Version:  6.10.1          
 Severity:  normal                    |     Resolution:  fixed           
 Keywords:                            |     Difficulty:  Unknown         
 Testcase:                            |   Architecture:  Unknown/Multiple
       Os:  Unknown/Multiple          |  
--------------------------------------+-------------------------------------
Changes (by simonpj):

  * status:  new => closed
  * resolution:  => fixed

Comment:

 I believe I've fixed this
 {{{
 Tue Oct 28 14:08:28 GMT Standard Time 2008  simonpj at microsoft.com
   * Fix Trac #2720: inlining and casts

   The issue here is what happens when we have

         (f |> co) x

   where f is itself marked INLINE.  We want callSiteInline to "see"
   the fact that the function is applied, and hence have some incentive
   to inline.  I've done this by extending CoreUnfold.CallCtxt with
   ValAppCtxt.  I think that should catch this case without messing up
   any of the others.
 }}}
 Do try it out. I'll close it meanwhile.

 Simon

-- 
Ticket URL: <http://hackage.haskell.org/trac/ghc/ticket/2720#comment:2>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler