[ ghc-Bugs-1249226 ] runInteractiveProcess and closed stdin.

[SourceForge.net]

Bugs item #1249226, was opened at 2005-08-01 04:28
Message generated for change (Comment added) made by simonmar
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=108032&aid=1249226&group_id=8032

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: libraries/base
Group: None
>Status: Closed
>Resolution: Fixed
Priority: 5
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Nobody/Anonymous (nobody)
Summary: runInteractiveProcess and closed stdin.

Initial Comment:
Hello,

The System.Process.runInteractiveProcess function
doesn't seem to provide the child process with a stdin
handle when the parent's stdin is closed. Below is a
small example:

import System.Process
import Control.Concurrent
import System.IO

main = do
  hClose stdin -- everything works as expected if the
handle isn't closed.
  putStrLn "Running cat ..."
  (inp, out, err, pid) <- runInteractiveProcess "cat"
[] Nothing Nothing
  forkIO (hPutStrLn inp "foo" >> hClose inp)
  forkIO (putStrLn =<< hGetContents out)
  forkIO (putStrLn =<< hGetContents err)
  -- Don't want to deal with waitForProcess and
-threaded right now.
  threadDelay 1000000
  return ()

Running this example produces the error

% ghc Run.hs -o run
% ./run
Running cat ...

cat: -: Bad file descriptor
cat: closing standard input: Bad file descriptor


I think the bug is in
fptools/libraries/base/cbits/runProcess.c:
//...
    pipe(fdStdInput);
//...
        dup2 (fdStdInput[0], STDIN_FILENO);
/...	
	close(fdStdInput[0]);
//...

pipe(...) will assign the lowest available file
descriptors, i.e. 0 if stdin is closed. The dup2 won't
do anything, since src and dest fds are identical, so
close(...) will close the child's stdin immediately.


% uname -a
Linux mthomas 2.6.12 #2 Thu Jul 21 07:51:44 EDT 2005
i686 GNU/Linux
% ghc --version
The Glorious Glasgow Haskell Compilation System,
version 6.5.20050728

Thanks,

-- Thomas Jäger

----------------------------------------------------------------------

>Comment By: Simon Marlow (simonmar)
Date: 2005-08-01 13:24

Message:
Logged In: YES 
user_id=48280

Thanks, excellent report.  I've fixed the bug and added your
test program to the test suite.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=108032&aid=1249226&group_id=8032