[GHC] #16212: API Annotations: Parens not attached correctly for ClassDecl

[GHC]

#16212: API Annotations: Parens not attached correctly for ClassDecl
-------------------------------------+-------------------------------------
        Reporter:  alanz             |                Owner:  alanz
            Type:  bug               |               Status:  new
        Priority:  normal            |            Milestone:  8.8.1
       Component:  Compiler          |              Version:  8.6.3
  (Parser)                           |
      Resolution:                    |             Keywords:
Operating System:  Unknown/Multiple  |         Architecture:
 Type of failure:  Incorrect API     |  Unknown/Multiple
  annotation                         |            Test Case:
      Blocked By:                    |             Blocking:
 Related Tickets:                    |  Differential Rev(s):
       Wiki Page:                    |
-------------------------------------+-------------------------------------

Comment (by sgraf):

 This is the diff of the two diffs:

 {{{#!patch
 --- /tmp/orig.diff      2019-01-31 15:46:25.327999736 +0100
 +++ /tmp/master.diff    2019-01-31 15:52:36.222476816 +0100
 @@ -253,24 +253,17 @@
  +
  +data Foo (a) b = Foo { av :: a, bv :: b }
  diff --git a/testsuite/tests/ghc-api/annotations/all.T b/testsuite/tests
 /ghc-api/annotations/all.T
 -index 49f0780021..4bb72926ca 100644
 +index 97c3c60c21..8002630b53 100644
  --- a/testsuite/tests/ghc-api/annotations/all.T
  +++ b/testsuite/tests/ghc-api/annotations/all.T
 -@@ -38,8 +38,7 @@ test('T10399',      [extra_files(['Test10399.hs']),
 -                      ignore_stderr], run_command, ['$MAKE -s --no-print-
 directory T10399'])
 +@@ -38,9 +38,7 @@ test('T10399',      [extra_files(['Test10399.hs']),
 +                      ignore_stderr], makefile_test, ['T10399'])
   test('T10313',      [extra_files(['Test10313.hs', 'stringSource.hs']),
 -                      ignore_stderr], run_command, ['$MAKE -s --no-print-
 directory T10313'])
 +                      ignore_stderr], makefile_test, ['T10313'])
  -# Stricter tests from trac #16217 now causes this to fail. Will be fixed
 for trac #16212
 --test('T11018',      [expect_broken(11018),extra_files(['Test11018.hs']),
 +-test('T11018',      [expect_broken(11018),
 +-                     extra_files(['Test11018.hs']),
  +test('T11018',      [extra_files(['Test11018.hs']),
 -                      ignore_stderr], run_command, ['$MAKE -s --no-print-
 directory T11018'])
 +                      ignore_stderr], makefile_test, ['T11018'])
   test('bundle-export', [extra_files(['BundleExport.hs']),
 -                        ignore_stderr], run_command, ['$MAKE -s --no-
 print-directory bundle-export'])
 -@@ -60,6 +59,5 @@ test('T13163',      [extra_files(['Test13163.hs']),
 -                      ignore_stderr], run_command, ['$MAKE -s --no-print-
 directory T13163'])
 - test('T15303',      [extra_files(['Test15303.hs']),
 -                      ignore_stderr], run_command, ['$MAKE -s --no-print-
 directory T15303'])
 --# Stricter tests from trac #16217 now causes this to fail. Will be fixed
 for trac #16212
 --test('T16212',      [expect_broken(16212),extra_files(['Test16212.hs']),
 -+test('T16212',      [extra_files(['Test16212.hs']),
 -                      ignore_stderr], run_command, ['$MAKE -s --no-print-
 directory T16212'])
 +                        ignore_stderr], makefile_test, ['bundle-export'])
 }}}

 Appearently `makefile_test` is a new short-hand for `$MAKE -s --no-print-
 directory {target}` and the bottom part just re-activates T16212.

 I re-applied that part in
 https://gitlab.haskell.org/ghc/ghc/merge_requests/266.

-- 
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/16212#comment:6>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler