[GHC] #15495: Handling Source Locations via TTG

GHC ghc-devs at haskell.org
Sat Nov 24 10:30:40 UTC 2018


#15495: Handling Source Locations via TTG
-------------------------------------+-------------------------------------
        Reporter:  Shayan-Najd       |                Owner:  (none)
            Type:  task              |               Status:  new
        Priority:  normal            |            Milestone:  ⊥
       Component:  Compiler          |              Version:
      Resolution:                    |             Keywords:
Operating System:  Unknown/Multiple  |         Architecture:
                                     |  Unknown/Multiple
 Type of failure:  None/Unknown      |            Test Case:
      Blocked By:                    |             Blocking:
 Related Tickets:                    |  Differential Rev(s):  Phab:D5036
       Wiki Page:                    |
-------------------------------------+-------------------------------------

Comment (by Alan Zimmerman <alan.zimm@…>):

 In [changeset:"509d5be69c7507ba5d0a5f39ffd1613a59e73eea/ghc"
 509d5be6/ghc]:
 {{{
 #!CommitTicketReference repository="ghc"
 revision="509d5be69c7507ba5d0a5f39ffd1613a59e73eea"
 [TTG: Handling Source Locations] Foundation and Pat

 This patch removes the ping-pong style from HsPat (only, for now),
 using the plan laid out at
 https://ghc.haskell.org/trac/ghc/wiki/ImplementingTreesThatGrow/HandlingSourceLocations
 (solution
 A).

 - the class `HasSrcSpan`, and its functions (e.g., `cL` and `dL`), are
 introduced
 - some instances of `HasSrcSpan` are introduced
 - some constructors `L` are replaced with `cL`
 - some patterns `L` are replaced with `dL->L` view pattern
 - some type annotation are necessarily updated (e.g., `Pat p` --> `Pat
 (GhcPass p)`)

 Phab diff: D5036
 Trac Issues #15495

 Updates haddock submodule
 }}}

-- 
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/15495#comment:6>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler


More information about the ghc-tickets mailing list