[GHC] #13114: UniqSet definition seems shady

GHC ghc-devs at haskell.org
Tue Nov 13 14:47:54 UTC 2018


#13114: UniqSet definition seems shady
-------------------------------------+-------------------------------------
        Reporter:  dfeuer            |                Owner:  dfeuer
            Type:  task              |               Status:  closed
        Priority:  low               |            Milestone:  8.2.1
       Component:  Compiler          |              Version:  8.1
      Resolution:  fixed             |             Keywords:
Operating System:  Unknown/Multiple  |         Architecture:
                                     |  Unknown/Multiple
 Type of failure:  None/Unknown      |            Test Case:
      Blocked By:                    |             Blocking:
 Related Tickets:                    |  Differential Rev(s):  Phab:D3146
       Wiki Page:                    |
-------------------------------------+-------------------------------------

Comment (by Sebastian Graf <sebastian.graf@…>):

 In [changeset:"5b98a38a32f2bc8491dc897631be8892919e2143/ghc"
 5b98a38a/ghc]:
 {{{
 #!CommitTicketReference repository="ghc"
 revision="5b98a38a32f2bc8491dc897631be8892919e2143"
 Make `UniqDSet` a newtype

 Summary:
 This brings the situation of `UniqDSet` in line with `UniqSet`.

 @dfeuer said in D3146#92820 that he would do this, but probably
 never got around to it.

 Validated locally.

 Reviewers: AndreasK, mpickering, bgamari, dfeuer, simonpj

 Reviewed By: simonpj

 Subscribers: simonpj, rwbarton, carter, dfeuer

 GHC Trac Issues: #15879, #13114

 Differential Revision: https://phabricator.haskell.org/D5313
 }}}

-- 
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/13114#comment:3>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler


More information about the ghc-tickets mailing list