[GHC] #14613: Validate Failure On OSX -- implicit fall through error for machO linker support (master == ghc8.5)

GHC ghc-devs at haskell.org
Fri Nov 2 21:13:52 UTC 2018


#14613: Validate Failure On OSX -- implicit fall through error for machO linker
support  (master == ghc8.5)
-------------------------------------+-------------------------------------
        Reporter:  carter            |                Owner:  (none)
            Type:  bug               |               Status:  patch
        Priority:  normal            |            Milestone:  8.6.2
       Component:  Compiler          |              Version:  8.3
  (Linking)                          |
      Resolution:                    |             Keywords:
Operating System:  MacOS X           |         Architecture:  x86_64
                                     |  (amd64)
 Type of failure:  None/Unknown      |            Test Case:
      Blocked By:                    |             Blocking:
 Related Tickets:                    |  Differential Rev(s):  Phab:D5292
       Wiki Page:                    |
-------------------------------------+-------------------------------------

Comment (by Ben Gamari <ben@…>):

 In [changeset:"6bb8aaa3b4fcebf8f0de2f81f00dcc20b857c4f5/ghc"
 6bb8aaa3/ghc]:
 {{{
 #!CommitTicketReference repository="ghc"
 revision="6bb8aaa3b4fcebf8f0de2f81f00dcc20b857c4f5"
 rts: Add FALLTHROUGH macro

 Instead of using the GCC `/* fallthrough */` syntax we now use the
 `__attribute__((fallthrough))`, which Phyx says should be more portable
 than the former.

 Also adds a missing fallthrough annotation in the MachO linker,
 fixing #14613.

 Reviewers: erikd, simonmar

 Reviewed By: simonmar

 Subscribers: rwbarton, carter

 GHC Trac Issues: #14613

 Differential Revision: https://phabricator.haskell.org/D5292
 }}}

-- 
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/14613#comment:6>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler


More information about the ghc-tickets mailing list