[GHC] #15559: fromJust has no HasCallStack

GHC ghc-devs at haskell.org
Fri Nov 2 00:34:15 UTC 2018


#15559: fromJust has no HasCallStack
-------------------------------------+-------------------------------------
        Reporter:  nomeata           |                Owner:  (none)
            Type:  feature request   |               Status:  patch
        Priority:  normal            |            Milestone:  8.6.1
       Component:  Core Libraries    |              Version:  8.4.3
      Resolution:                    |             Keywords:  newcomer
Operating System:  Unknown/Multiple  |         Architecture:
                                     |  Unknown/Multiple
 Type of failure:  None/Unknown      |            Test Case:
      Blocked By:                    |             Blocking:
 Related Tickets:                    |  Differential Rev(s):  Phab:D5256
       Wiki Page:                    |
-------------------------------------+-------------------------------------

Comment (by Ben Gamari <ben@…>):

 In [changeset:"614028e3b02a5b71a9fbf9c7028f270760ccdab2/ghc" 614028e/ghc]:
 {{{
 #!CommitTicketReference repository="ghc"
 revision="614028e3b02a5b71a9fbf9c7028f270760ccdab2"
 Data.Maybe: add callstack for fromJust (Trac #15559)

 Per feature request, add `HasCallStack` to `fromJust` in `Data.Maybe`
 and use `error` instead of `errorWithoutStackTrace`. This allows
 `fromJust` to print call stacks when throwing the error.

 Also add a new test case for the behaviour, modify existing test cases
 for new signature

 Test Plan: New test cases

 Reviewers: hvr, bgamari

 Reviewed By: bgamari

 Subscribers: ulysses4ever, rwbarton, carter

 GHC Trac Issues: #15559

 Differential Revision: https://phabricator.haskell.org/D5256
 }}}

-- 
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/15559#comment:10>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler


More information about the ghc-tickets mailing list