[GHC] #8619: Support anonymous string literals in C-- (OR) give better ASSERT failure messages in C--
GHC
ghc-devs at haskell.org
Sun Jun 17 18:40:42 UTC 2018
#8619: Support anonymous string literals in C-- (OR) give better ASSERT failure
messages in C--
-------------------------------------+-------------------------------------
Reporter: ezyang | Owner: (none)
Type: feature request | Status: patch
Priority: low | Milestone:
Component: Compiler | Version: 7.7
Resolution: | Keywords:
Operating System: Unknown/Multiple | Architecture:
| Unknown/Multiple
Type of failure: Other | Test Case:
Blocked By: | Blocking:
Related Tickets: | Differential Rev(s): Phab:D4862
Wiki Page: |
-------------------------------------+-------------------------------------
Comment (by Ben Gamari <ben@…>):
In [changeset:"008ea12dd93b9f9104f0b532b278a31b719bafb8/ghc"
008ea12d/ghc]:
{{{
#!CommitTicketReference repository="ghc"
revision="008ea12dd93b9f9104f0b532b278a31b719bafb8"
Use __FILE__ for Cmm assertion locations, fix #8619
It seems like we currently support string literals in Cmm, so we can use
__LINE__ CPP macro in assertion macros. This improves error messages
that previously looked like
ASSERTION FAILED: file (null), line 1302
(null) part now shows the actual file name.
Also inline some single-use string literals in PrimOps.cmm.
Reviewers: bgamari, simonmar, erikd
Reviewed By: bgamari
Subscribers: rwbarton, thomie, carter
Differential Revision: https://phabricator.haskell.org/D4862
}}}
--
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/8619#comment:9>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler
More information about the ghc-tickets
mailing list