[GHC] #14845: TypeInType, index GADT by constraint witness

[GHC]

#14845: TypeInType, index GADT by constraint witness
-------------------------------------+-------------------------------------
        Reporter:  Iceland_jack      |                Owner:  (none)
            Type:  feature request   |               Status:  patch
        Priority:  normal            |            Milestone:
       Component:  Compiler          |              Version:  8.5
      Resolution:                    |             Keywords:  TypeInType
Operating System:  Unknown/Multiple  |         Architecture:
                                     |  Unknown/Multiple
 Type of failure:  None/Unknown      |            Test Case:
      Blocked By:                    |             Blocking:
 Related Tickets:  #13895, #15215    |  Differential Rev(s):  Phab:D4728
       Wiki Page:                    |
-------------------------------------+-------------------------------------

Comment (by Ben Gamari <ben@…>):

 In [changeset:"c63754118cf6c3d0947d0c611f1db39c78acf1b7/ghc" c637541/ghc]:
 {{{
 #!CommitTicketReference repository="ghc"
 revision="c63754118cf6c3d0947d0c611f1db39c78acf1b7"
 Provide a better error message for unpromotable data constructor contexts

 Trac #14845 brought to light a corner case where a data
 constructor could not be promoted (even with `-XTypeInType`) due to
 an unpromotable constraint in its context. However, the error message
 was less than helpful, so this patch adds an additional check to
 `tcTyVar` catch unpromotable data constructors like these //before//
 they're promoted, and to give a sensible error message in such cases.

 Test Plan: make test TEST="T13895 T14845"

 Reviewers: simonpj, goldfire, bgamari

 Reviewed By: bgamari

 Subscribers: rwbarton, thomie, carter

 GHC Trac Issues: #13895, #14845

 Differential Revision: https://phabricator.haskell.org/D4728
 }}}

-- 
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/14845#comment:20>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler