[GHC] #14627: qAddTopDecls: can't convert top-level declarations

[GHC]

#14627: qAddTopDecls: can't convert top-level declarations
-------------------------------------+-------------------------------------
        Reporter:  tianxiaogu        |                Owner:  mgsloan
            Type:  bug               |               Status:  closed
        Priority:  normal            |            Milestone:  8.8.1
       Component:  Template Haskell  |              Version:  8.2.2
      Resolution:  fixed             |             Keywords:
Operating System:  Unknown/Multiple  |         Architecture:
 Type of failure:  Compile-time      |  Unknown/Multiple
  crash or panic                     |            Test Case:  th/T14627
      Blocked By:                    |             Blocking:
 Related Tickets:                    |  Differential Rev(s):  Phab:D4914
       Wiki Page:                    |
-------------------------------------+-------------------------------------

Comment (by Ben Gamari <ben@…>):

 In [changeset:"774f366ebe58023fc50ba346894227b14816fe67/ghc" 774f366/ghc]:
 {{{
 #!CommitTicketReference repository="ghc"
 revision="774f366ebe58023fc50ba346894227b14816fe67"
 Fail instead of panic-ing when qAddTopDecls has conversion error

 See https://ghc.haskell.org/trac/ghc/ticket/14627 for an example where
 GHC panics when using qAddTopDecls on [d| f = Bool |]. Instead, it
 should be a normal error message, and that's what this change is for. It
 does not entirely resolve Trac#14627, since "Illegal variable name:
 'bool'" isn't a very good error for this cirumstance.

 Test Plan: Manually tested.

 Reviewers: goldfire, bgamari

 Reviewed By: goldfire

 Subscribers: rwbarton, thomie, carter

 Differential Revision: https://phabricator.haskell.org/D4914
 }}}

-- 
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/14627#comment:11>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler