[GHC] #15315: Renamer plugins could run after each group has been renamed

GHC ghc-devs at haskell.org
Thu Jul 12 19:06:23 UTC 2018


#15315: Renamer plugins could run after each group has been renamed
-------------------------------------+-------------------------------------
        Reporter:  mpickering        |                Owner:  (none)
            Type:  bug               |               Status:  patch
        Priority:  normal            |            Milestone:  8.6.1
       Component:  Compiler          |              Version:  8.4.3
      Resolution:                    |             Keywords:  plugins
Operating System:  Unknown/Multiple  |         Architecture:
                                     |  Unknown/Multiple
 Type of failure:  None/Unknown      |            Test Case:
      Blocked By:                    |             Blocking:
 Related Tickets:                    |  Differential Rev(s):  Phab:D4947
       Wiki Page:                    |
-------------------------------------+-------------------------------------

Comment (by Ben Gamari <ben@…>):

 In [changeset:"1a79270c72cfcd98d683cfe7b2c777d8dd353b78/ghc" 1a79270/ghc]:
 {{{
 #!CommitTicketReference repository="ghc"
 revision="1a79270c72cfcd98d683cfe7b2c777d8dd353b78"
 Run the renamed source plugin after each HsGroup

 This allows modification of each `HsGroup` after it has been renamed.

 The old behaviour of keeping the renamed source until later can be
 recovered if desired by using the `keepRenamedSource` plugin but it
 shouldn't really be necessary as it can be inspected in the `TcGblEnv`.

 Reviewers: nboldi, bgamari, alpmestan

 Reviewed By: nboldi, alpmestan

 Subscribers: alpmestan, rwbarton, thomie, carter

 GHC Trac Issues: #15315

 Differential Revision: https://phabricator.haskell.org/D4947
 }}}

-- 
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/15315#comment:2>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler


More information about the ghc-tickets mailing list