[GHC] #15308: Error message prints explicit kinds when it shouldn't

GHC ghc-devs at haskell.org
Thu Jul 5 13:51:59 UTC 2018


#15308: Error message prints explicit kinds when it shouldn't
-------------------------------------+-------------------------------------
        Reporter:  RyanGlScott       |                Owner:  (none)
            Type:  bug               |               Status:  patch
        Priority:  normal            |            Milestone:  8.6.1
       Component:  Compiler (Type    |              Version:  8.4.3
  checker)                           |
      Resolution:                    |             Keywords:  TypeInType
Operating System:  Unknown/Multiple  |         Architecture:
 Type of failure:  Poor/confusing    |  Unknown/Multiple
  error message                      |            Test Case:
      Blocked By:                    |             Blocking:
 Related Tickets:                    |  Differential Rev(s):  Phab:D4891
       Wiki Page:                    |
-------------------------------------+-------------------------------------

Comment (by Ryan Scott <ryan.gl.scott@…>):

 In [changeset:"93b7ac8d73885369f61f6eb6147352d45de4e957/ghc" 93b7ac8/ghc]:
 {{{
 #!CommitTicketReference repository="ghc"
 revision="93b7ac8d73885369f61f6eb6147352d45de4e957"
 Fix #15308 by suppressing invisble args more rigorously

 Summary:
 There was a buglet in `stripInvisArgs` (which is part of the
 pretty-printing pipeline for types) in which only invisble arguments
 which came before any visible arguments would be suppressed, but any
 invisble arguments that came //after// visible ones would still be
 printed, even if `-fprint-explicit-kinds`  wasn't enabled.
 The fix is simple: make `stripInvisArgs` recursively process the
 remaining types even after a visible argument is encountered.

 Test Plan: make test TEST=T15308

 Reviewers: goldfire, bgamari

 Reviewed By: bgamari

 Subscribers: simonpj, rwbarton, thomie, carter

 GHC Trac Issues: #15308

 Differential Revision: https://phabricator.haskell.org/D4891
 }}}

-- 
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/15308#comment:3>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler


More information about the ghc-tickets mailing list