[GHC] #14790: eqTypeRep does not inline

GHC ghc-devs at haskell.org
Thu Feb 15 08:50:17 UTC 2018


#14790: eqTypeRep does not inline
-------------------------------------+-------------------------------------
        Reporter:  dfeuer            |                Owner:  (none)
            Type:  bug               |               Status:  patch
        Priority:  normal            |            Milestone:  8.6.1
       Component:  Compiler          |              Version:  8.4.1-alpha2
      Resolution:                    |             Keywords:
Operating System:  Unknown/Multiple  |         Architecture:
 Type of failure:  Runtime           |  Unknown/Multiple
  performance bug                    |            Test Case:
      Blocked By:                    |             Blocking:
 Related Tickets:                    |  Differential Rev(s):  Phab:D4405
       Wiki Page:                    |
-------------------------------------+-------------------------------------

Comment (by David Feuer <David.Feuer@…>):

 In [changeset:"8529fbba309cd692bbbb0386321515d05a6ed256/ghc"
 8529fbba/ghc]:
 {{{
 #!CommitTicketReference repository="ghc"
 revision="8529fbba309cd692bbbb0386321515d05a6ed256"
 Get eqTypeRep to inline

 GHC didn't inline `eqTypeRep`, presumably because it ended up
 being too big. This was unfortunate because it produces a
 `Maybe`, which will almost always be scrutinized immediately.

 Split `eqTypeRep` into a worker and a tiny wrapper, and mark the
 wrapper `INLINABLE`. This change actually seems to reduce Core size,
 at least in a small test.

 Reviewers: hvr, bgamari, mpickering

 Reviewed By: mpickering

 Subscribers: mpickering, rwbarton, thomie, carter

 GHC Trac Issues: #14790

 Differential Revision: https://phabricator.haskell.org/D4405
 }}}

-- 
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/14790#comment:17>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler


More information about the ghc-tickets mailing list