[GHC] #5889: -fno-prof-count-entries leads to linking errors

GHC ghc-devs at haskell.org
Tue Feb 13 07:03:13 UTC 2018


#5889: -fno-prof-count-entries leads to linking errors
-------------------------------------+-------------------------------------
        Reporter:  akio              |                Owner:  bgamari
            Type:  bug               |               Status:  patch
        Priority:  highest           |            Milestone:  8.4.1
       Component:  Compiler          |              Version:  8.3
      Resolution:                    |             Keywords:
Operating System:  Linux             |         Architecture:  x86_64
                                     |  (amd64)
 Type of failure:  GHC rejects       |            Test Case:
  valid program                      |  profiling/should_compile/T5889
      Blocked By:                    |             Blocking:
 Related Tickets:                    |  Differential Rev(s):  Phab:D4325
       Wiki Page:                    |
-------------------------------------+-------------------------------------

Comment (by Ömer Sinan Ağacan <omeragacan@…>):

 In [changeset:"5957405808fe89e9b108dc0bc3cf4b56aec37775/ghc" 5957405/ghc]:
 {{{
 #!CommitTicketReference repository="ghc"
 revision="5957405808fe89e9b108dc0bc3cf4b56aec37775"
 Collect CCs in CorePrep, including CCs in unfoldings

 This patch includes two changes:

 1. Move cost centre collection from `SCCfinal` to `CorePrep`, to be able
    to collect cost centres in unfoldings. `CorePrep` drops unfoldings, so
    that's the latest stage in the compilation pipeline for this.

    After this change `SCCfinal` no longer collects all cost centres, but
    it still generates & collects CAF cost centres + updates cost centre
    stacks of `StgRhsClosure` and `StgRhsCon`s.

    This fixes #5889.

 2. Initialize cost centre stack fields of `StgRhs` in `coreToStg`. With
    this we no longer need to update cost centre stack fields in
    `SCCfinal`, so that module is removed.

    Cost centre initialization explained in Note [Cost-centre
    initialization plan].

    Because with -fcaf-all we need to attach a new cost-centre to each
    CAF, `coreTopBindToStg` now returns `CollectedCCs`.

 Test Plan: validate

 Reviewers: simonpj, bgamari, simonmar

 Reviewed By: simonpj, bgamari

 Subscribers: rwbarton, thomie, carter

 GHC Trac Issues: #5889

 Differential Revision: https://phabricator.haskell.org/D4325
 }}}

-- 
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/5889#comment:31>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler


More information about the ghc-tickets mailing list