[GHC] #14790: eqTypeRep does not inline

GHC ghc-devs at haskell.org
Mon Feb 12 12:38:16 UTC 2018


#14790: eqTypeRep does not inline
-------------------------------------+-------------------------------------
        Reporter:  dfeuer            |                Owner:  (none)
            Type:  bug               |               Status:  new
        Priority:  normal            |            Milestone:  8.6.1
       Component:  Compiler          |              Version:  8.4.1-alpha2
      Resolution:                    |             Keywords:
Operating System:  Unknown/Multiple  |         Architecture:
 Type of failure:  Runtime           |  Unknown/Multiple
  performance bug                    |            Test Case:
      Blocked By:                    |             Blocking:
 Related Tickets:                    |  Differential Rev(s):
       Wiki Page:                    |
-------------------------------------+-------------------------------------

Comment (by mpickering):

 Without a proper analysis of why the problem occurred in the first place,
 it can't be evaluated why the fix works at all or whether it is correct.

 Adding an `INLINE` pragma is a very big commitment when there is already a
 reason that the function is not inlined. Why is the wrapper necessary in
 addition to the pragma?

 I think you are right thought that the `NOINLINE[0]` pragmas I suggested
 won't make a difference to the unfolding. So perhaps just adding an
 `INLINABLE` pragma is the correct solution?

 I don't understand your 3rd point. There doesn't appear to be much
 advantage at all of knowing either argument as the quality condition will
 seemingly never simplify further?

-- 
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/14790#comment:10>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler


More information about the ghc-tickets mailing list