[GHC] #15550: Names of RULES aren't quoted in -ddump-splices

GHC ghc-devs at haskell.org
Mon Aug 27 13:39:27 UTC 2018


#15550: Names of RULES aren't quoted in -ddump-splices
-------------------------------------+-------------------------------------
        Reporter:  RyanGlScott       |                Owner:  (none)
            Type:  bug               |               Status:  patch
        Priority:  normal            |            Milestone:  8.6.1
       Component:  Template Haskell  |              Version:  8.4.3
      Resolution:                    |             Keywords:
Operating System:  Unknown/Multiple  |         Architecture:
                                     |  Unknown/Multiple
 Type of failure:  None/Unknown      |            Test Case:
      Blocked By:                    |             Blocking:
 Related Tickets:                    |  Differential Rev(s):  Phab:D5090
       Wiki Page:                    |
-------------------------------------+-------------------------------------

Comment (by Krzysztof Gogolewski <krz.gogolewski@…>):

 In [changeset:"5e6cf2a9301a5473ff9c5319b96de941b1ad72dd/ghc"
 5e6cf2a9/ghc]:
 {{{
 #!CommitTicketReference repository="ghc"
 revision="5e6cf2a9301a5473ff9c5319b96de941b1ad72dd"
 Fix #15550 by quoting RULE names during TH conversion

 Summary:
 When converting a `RuleP` to a GHC source `RuleD` during TH
 conversion, we were stupidly not double-quoting the name of the rule.
 Easily fixed.

 Test Plan: make test TEST=T15550

 Reviewers: goldfire, bgamari, simonpj

 Reviewed By: simonpj

 Subscribers: simonpj, rwbarton, carter

 GHC Trac Issues: #15550

 Differential Revision: https://phabricator.haskell.org/D5090
 }}}

-- 
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/15550#comment:4>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler


More information about the ghc-tickets mailing list