[GHC] #14483: getExecutablePath from System.Environment in base should follow symlinks properly.
GHC
ghc-devs at haskell.org
Sat Aug 25 10:24:47 UTC 2018
#14483: getExecutablePath from System.Environment in base should follow symlinks
properly.
-------------------------------------+-------------------------------------
Reporter: angerman | Owner: alpmestan
Type: bug | Status: closed
Priority: normal | Milestone: 8.4.1
Component: Compiler | Version: 8.3
Resolution: fixed | Keywords:
Operating System: Unknown/Multiple | Architecture:
| Unknown/Multiple
Type of failure: None/Unknown | Test Case:
Blocked By: | Blocking:
Related Tickets: | Differential Rev(s): D4227
Wiki Page: |
-------------------------------------+-------------------------------------
Comment (by Tamar Christina <tamar@…>):
In [changeset:"c523525b0e434d848f6e47ea3f9a37485965fa79/ghc" c523525/ghc]:
{{{
#!CommitTicketReference repository="ghc"
revision="c523525b0e434d848f6e47ea3f9a37485965fa79"
ghc, ghc-pkg: use getExecutablePath on Windows when base >= 4.11.0
Summary:
This completes the work started in D4227 by using just 'getExecutablePath'
in ghc and ghc-pkg when building with base >= 4.11.0.
On the long term, we will be able to simply kill the existing code that
follows (or not) symlinks and just get this behaviour for free from
getExecutable. For now we however have to require base >= 4.11.0 to be
able
to just use getExecutablePath under Windows, and use the current code when
building with an older base.
Original code by @alpmestan commandeering since patch has been stale
and bug remains open.
Test Plan: Validate
Reviewers: angerman, bgamari, erikd, alpmestan
Reviewed By: bgamari
Subscribers: carter, rwbarton, thomie
GHC Trac Issues: #14483
Differential Revision: https://phabricator.haskell.org/D4229
}}}
--
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/14483#comment:8>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler
More information about the ghc-tickets
mailing list