[GHC] #314: #line pragmas not respected inside nested comments

GHC ghc-devs at haskell.org
Tue Aug 21 22:56:23 UTC 2018


#314: #line pragmas not respected inside nested comments
-------------------------------------+-------------------------------------
        Reporter:  nobody            |                Owner:  (none)
            Type:  bug               |               Status:  patch
        Priority:  normal            |            Milestone:  8.8.1
       Component:  Compiler          |              Version:  6.4
  (Parser)                           |
      Resolution:  None              |             Keywords:
Operating System:  Unknown/Multiple  |         Architecture:
                                     |  Unknown/Multiple
 Type of failure:  None/Unknown      |            Test Case:  read032
      Blocked By:                    |             Blocking:
 Related Tickets:                    |  Differential Rev(s):  Phab:D4934
       Wiki Page:                    |
-------------------------------------+-------------------------------------

Comment (by Ben Gamari <ben@…>):

 In [changeset:"02518f9d99c2d038384263f9e039efcb09bc96ff/ghc" 02518f9/ghc]:
 {{{
 #!CommitTicketReference repository="ghc"
 revision="02518f9d99c2d038384263f9e039efcb09bc96ff"
 Fix #line pragmas in nested comments

 When parsing a nested comment or nested doc comment in the lexer, if we
 see a line starting with '#' we attempt to parse a #line pragma. This
 fixes how ghc handles output of the C preproccesor (-cpp flag) when the
 original source has C comments or pragmas inside haskell comments.

 Updates haddock submodule.

 Test Plan: ./validate

 Reviewers: bgamari

 Reviewed By: bgamari

 Subscribers: rwbarton, thomie, carter

 GHC Trac Issues: #314

 Differential Revision: https://phabricator.haskell.org/D4934
 }}}

-- 
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/314#comment:21>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler


More information about the ghc-tickets mailing list