[GHC] #15234: WARNING in hptSomeThingsBelowUs when using a source plugin

[GHC]

#15234: WARNING in hptSomeThingsBelowUs when using a source plugin
-------------------------------------+-------------------------------------
        Reporter:  mpickering        |                Owner:  (none)
            Type:  bug               |               Status:  patch
        Priority:  highest           |            Milestone:  8.6.1
       Component:  Compiler          |              Version:  8.4.3
      Resolution:                    |             Keywords:
                                     |  SourcePlugins, plugins
Operating System:  Unknown/Multiple  |         Architecture:
                                     |  Unknown/Multiple
 Type of failure:  None/Unknown      |            Test Case:
      Blocked By:                    |             Blocking:
 Related Tickets:                    |  Differential Rev(s):  Phab:D4937
       Wiki Page:                    |
-------------------------------------+-------------------------------------

Comment (by Ben Gamari <ben@…>):

 In [changeset:"52065e95c6df89d0048c6e3f35d6cc26ce8246f9/ghc" 52065e9/ghc]:
 {{{
 #!CommitTicketReference repository="ghc"
 revision="52065e95c6df89d0048c6e3f35d6cc26ce8246f9"
 Plugin dependency information is stored separately

 We need to store the used plugins so that we recompile
 a module when a plugin that it uses is recompiled.

 However, storing the `ModuleName`s of the plugins used by a
 module in the `dep_mods` field made the rest of GHC think
 that they belong in the HPT, causing at least the issues
 reported in #15234

 We therefor store the `ModuleName`s of the plugins in a
 new field, `dep_plgins`, which is only used the the
 recompilation logic.

 Reviewers: mpickering, bgamari

 Reviewed By: mpickering, bgamari

 Subscribers: alpmestan, rwbarton, thomie, carter

 GHC Trac Issues: #15234

 Differential Revision: https://phabricator.haskell.org/D4937
 }}}

-- 
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/15234#comment:9>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler