[GHC] #14235: Suspiciously missing closure types in isRetainer

GHC ghc-devs at haskell.org
Tue Sep 19 17:43:32 UTC 2017


#14235: Suspiciously missing closure types in isRetainer
-------------------------------------+-------------------------------------
        Reporter:  bgamari           |                Owner:  (none)
            Type:  bug               |               Status:  patch
        Priority:  high              |            Milestone:  8.4.1
       Component:  Runtime System    |              Version:  8.2.1
      Resolution:                    |             Keywords:
Operating System:  Unknown/Multiple  |         Architecture:
                                     |  Unknown/Multiple
 Type of failure:  None/Unknown      |            Test Case:
      Blocked By:                    |             Blocking:
 Related Tickets:                    |  Differential Rev(s):  Phab:D3967
       Wiki Page:                    |
-------------------------------------+-------------------------------------

Comment (by Ben Gamari <ben@…>):

 In [changeset:"6252292d4f4061f6e55c7f92a399160147c4ca74/ghc"
 6252292d/ghc]:
 {{{
 #!CommitTicketReference repository="ghc"
 revision="6252292d4f4061f6e55c7f92a399160147c4ca74"
 rts/RetainerProfile: Adding missing closure types to isRetainer

 orzo in `#ghc` reported seeing a crash due to the retainer profiler
 encountering
 a BLOCKING_QUEUE closure, which isRetainer didn't know about. I performed
 an
 audit to make sure that all of the valid closure types were listed; they
 weren't. This is my guess of how they should appear.

 Test Plan: Validate

 Reviewers: simonmar, austin, erikd

 Reviewed By: simonmar

 Subscribers: rwbarton, thomie

 GHC Trac Issues: #14235

 Differential Revision: https://phabricator.haskell.org/D3967
 }}}

-- 
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/14235#comment:2>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler


More information about the ghc-tickets mailing list