[GHC] #14483: getExecutablePath from System.Environment in base should follow symlinks properly.

GHC ghc-devs at haskell.org
Mon Nov 27 15:21:30 UTC 2017


#14483: getExecutablePath from System.Environment in base should follow symlinks
properly.
-------------------------------------+-------------------------------------
        Reporter:  angerman          |                Owner:  alpmestan
            Type:  bug               |               Status:  patch
        Priority:  normal            |            Milestone:  8.6.1
       Component:  Compiler          |              Version:  8.3
      Resolution:                    |             Keywords:
Operating System:  Unknown/Multiple  |         Architecture:
                                     |  Unknown/Multiple
 Type of failure:  None/Unknown      |            Test Case:
      Blocked By:                    |             Blocking:
 Related Tickets:                    |  Differential Rev(s):  D4227
       Wiki Page:                    |
-------------------------------------+-------------------------------------

Comment (by Ben Gamari <ben@…>):

 In [changeset:"62823668c48e13290e2ffe0d593a9f6a95cf628b/ghc"
 62823668/ghc]:
 {{{
 #!CommitTicketReference repository="ghc"
 revision="62823668c48e13290e2ffe0d593a9f6a95cf628b"
 Follow symlinks in the Win32 code for System.Environment.getExecutablePath

 This partially addresses #14483 by fixing the Windows implementation of
 System.Environment.getExecutablePath. This is achieved by using
 GetFinalPathNameByHandleW to resolve potential symlinks, while making
 sure we do not get back a UNC path (see #14460).

 Test Plan: Validate

 Reviewers: Phyx, bgamari, angerman, hvr, goldfire

 Reviewed By: Phyx, bgamari

 GHC Trac Issues: #14483

 Differential Revision: https://phabricator.haskell.org/D4227
 }}}

-- 
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/14483#comment:5>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler


More information about the ghc-tickets mailing list