[GHC] #14425: approxRational is wrong when (rat - eps) overflows in negative direction

GHC ghc-devs at haskell.org
Thu Nov 9 23:34:54 UTC 2017


#14425: approxRational is wrong when (rat - eps) overflows in negative direction
-------------------------------------+-------------------------------------
        Reporter:  danielk           |                Owner:  (none)
            Type:  bug               |               Status:  patch
        Priority:  normal            |            Milestone:  8.4.1
       Component:  libraries/base    |              Version:  8.2.1
      Resolution:                    |             Keywords:
Operating System:  Unknown/Multiple  |         Architecture:
 Type of failure:  Incorrect result  |  Unknown/Multiple
  at runtime                         |            Test Case:  T14425
      Blocked By:                    |             Blocking:
 Related Tickets:                    |  Differential Rev(s):  Phab:D4168
       Wiki Page:                    |
-------------------------------------+-------------------------------------

Comment (by Ben Gamari <ben@…>):

 In [changeset:"c59d6da8639fd88919090b29cf4e76c4d0d8bbde/ghc" c59d6da/ghc]:
 {{{
 #!CommitTicketReference repository="ghc"
 revision="c59d6da8639fd88919090b29cf4e76c4d0d8bbde"
 base: Normalize style of approxRational

 Stumbled upon this odd bit of style while looking at #14425. Usually I
 don't like to do this sort of reformatting, but this seemed like it
 would be necessary in the course fo fixing #14425.

 Reviewers: hvr

 Subscribers: rwbarton, thomie

 Differential Revision: https://phabricator.haskell.org/D4168
 }}}

-- 
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/14425#comment:5>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler


More information about the ghc-tickets mailing list