[GHC] #13411: GCC driver fails on Windows 10 15019+

[GHC]

#13411: GCC driver fails on Windows 10 15019+
-------------------------------------+-------------------------------------
        Reporter:  Phyx-             |                Owner:  Phyx-
            Type:  bug               |               Status:  patch
        Priority:  highest           |            Milestone:  8.2.1
       Component:  Driver            |              Version:  8.0.2
      Resolution:                    |             Keywords:
Operating System:  Windows           |         Architecture:
 Type of failure:  Compile-time      |  Unknown/Multiple
  crash or panic                     |            Test Case:
      Blocked By:                    |             Blocking:
 Related Tickets:                    |  Differential Rev(s):  Phab:D3319
       Wiki Page:                    |
-------------------------------------+-------------------------------------

Comment (by Ben Gamari <ben@…>):

 In [changeset:"4b673e804fb8598dac02596f107544c7f2ea263b/ghc" 4b673e8/ghc]:
 {{{
 #!CommitTicketReference repository="ghc"
 revision="4b673e804fb8598dac02596f107544c7f2ea263b"
 Fix Windows GCC driver

 In Windows 10 Insiders build 15019+ which will probably be released
 mainstream somewhere this year Microsoft seems to have started being
 stricter with API calls.

 The call to `FreeConsole` just after `CreateProcess` is making Windows
 treat the process
 as an interactive process. In which case it tries to use the `Desktop
 session` but fails resulting
 in the cryptic error reported.

 I don't understand why the call to `FreeConsole` was there and it
 doesn't seem to be needed,
 so removed.

 This fixes #13411

 Test Plan: ./validate, alternative just do anything with ghc which
 requires compilation.

 Reviewers: austin, bgamari, simonmar

 Reviewed By: bgamari

 Subscribers: rwbarton, thomie, #ghc_windows_task_force

 Differential Revision: https://phabricator.haskell.org/D3319
 }}}

--
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/13411#comment:4>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler