[GHC] #10830: maximumBy has a space leak
GHC
ghc-devs at haskell.org
Sat Mar 4 21:45:34 UTC 2017
#10830: maximumBy has a space leak
-------------------------------------+-------------------------------------
Reporter: NeilMitchell | Owner: (none)
Type: bug | Status: patch
Priority: high | Milestone: 8.2.1
Component: Core Libraries | Version: 7.10.2
Resolution: | Keywords:
Operating System: Unknown/Multiple | Architecture:
Type of failure: Runtime | Unknown/Multiple
performance bug | Test Case:
Blocked By: | Blocking:
Related Tickets: | Differential Rev(s): Phab:D1205,
Wiki Page: | Phab:D3019
-------------------------------------+-------------------------------------
Comment (by Ben Gamari <ben@…>):
In [changeset:"2e43848236a4b80015d8fb09a87f6f6a746c1365/ghc"
2e438482/ghc]:
{{{
#!CommitTicketReference repository="ghc"
revision="2e43848236a4b80015d8fb09a87f6f6a746c1365"
Fixes a spaceleak in `maximumBy` and `minimumBy` (#10830).
This involved changing the implementation from using
`foldr11` to using `foldl1`.
Test Plan: validate
Reviewers: austin, hvr, bgamari, dalaing, dfeuer
Reviewed By: bgamari
Subscribers: RyanGlScott, dfeuer, thomie
Differential Revision: https://phabricator.haskell.org/D3019
}}}
--
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/10830#comment:33>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler
More information about the ghc-tickets
mailing list