[GHC] #13340: Core top-level bindings no longer deduplicated

GHC ghc-devs at haskell.org
Wed Mar 1 19:48:24 UTC 2017


#13340: Core top-level bindings no longer deduplicated
-------------------------------------+-------------------------------------
        Reporter:  rwbarton          |                Owner:  (none)
            Type:  bug               |               Status:  new
        Priority:  highest           |            Milestone:  8.2.1
       Component:  Compiler          |              Version:  8.1
      Resolution:                    |             Keywords:
Operating System:  Unknown/Multiple  |         Architecture:
                                     |  Unknown/Multiple
 Type of failure:  None/Unknown      |            Test Case:
      Blocked By:                    |             Blocking:
 Related Tickets:                    |  Differential Rev(s):
       Wiki Page:                    |
-------------------------------------+-------------------------------------

Comment (by rwbarton):

 Simon, it looks like you implemented the first bullet point in your
 comment above in 55efc9718b520ef354e32c15c4b49cdfecce412f "Combine
 identical case alternatives in CSE", though the old version is commented
 out.
 {{{#!diff
 +noCSE :: InId -> Bool
 +noCSE id = not (isAlwaysActive (idInlineActivation id))
 +             -- See Note [CSE for INLINE and NOINLINE]
 +         || isAnyInlinePragma (idInlinePragma id)
 +             --isStableUnfolding (idUnfolding id)
 +             -- See Note [CSE for stable unfoldings]
 +         || isJoinId id
 +             -- See Note [CSE for join points?]
 }}}
 Did you mean to commit this in this form? It did fix the test associated
 to this ticket.

--
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/13340#comment:11>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler


More information about the ghc-tickets mailing list