[GHC] #14005: Explore moving from pretty to prettyprinter

GHC ghc-devs at haskell.org
Mon Jul 24 23:36:19 UTC 2017


#14005: Explore moving from pretty to prettyprinter
-------------------------------------+-------------------------------------
        Reporter:  bgamari           |                Owner:  (none)
            Type:  task              |               Status:  new
        Priority:  normal            |            Milestone:  8.4.1
       Component:  Compiler          |              Version:  8.0.1
      Resolution:                    |             Keywords:
Operating System:  Unknown/Multiple  |         Architecture:
                                     |  Unknown/Multiple
 Type of failure:  None/Unknown      |            Test Case:
      Blocked By:                    |             Blocking:
 Related Tickets:                    |  Differential Rev(s):  Phab:D3650
       Wiki Page:                    |
  wiki:PrettyErrors                  |
-------------------------------------+-------------------------------------

Comment (by Ben Gamari <ben@…>):

 In [changeset:"85a295d5607b5f8015bb3517601ced0d1adc29ef/ghc" 85a295d/ghc]:
 {{{
 #!CommitTicketReference repository="ghc"
 revision="85a295d5607b5f8015bb3517601ced0d1adc29ef"
 ghc-prim: Don't allocate a thunk for each unpacked UTF-8 character

 While debugging #14005 I noticed that unpackCStringUtf8# was allocating
 a thunk for each Unicode character that it unpacked. This seems hardly
 worthwhile given that the thunk's closure will be at least three words,
 whereas the Char itself will be only two and requires only a bit of bit
 twiddling to construct.

 Test Plan: Validate

 Reviewers: simonmar, austin

 Subscribers: dfeuer, rwbarton, thomie

 Differential Revision: https://phabricator.haskell.org/D3769
 }}}

-- 
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/14005#comment:11>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler


More information about the ghc-tickets mailing list