[GHC] #13948: GHC incorrectly suggests a data constructor is in scope in 8.2
GHC
ghc-devs at haskell.org
Tue Jul 11 18:36:19 UTC 2017
#13948: GHC incorrectly suggests a data constructor is in scope in 8.2
-------------------------------------+-------------------------------------
Reporter: RyanGlScott | Owner: (none)
Type: bug | Status: patch
Priority: normal | Milestone:
Component: Compiler | Version: 8.2.1-rc2
Resolution: | Keywords:
Operating System: Unknown/Multiple | Architecture:
Type of failure: Poor/confusing | Unknown/Multiple
error message | Test Case:
Blocked By: | Blocking:
Related Tickets: #13568 | Differential Rev(s): Phab:D3719
Wiki Page: |
-------------------------------------+-------------------------------------
Comment (by Ben Gamari <ben@…>):
In [changeset:"ba46e63f3d6f7d0438a0262f6711f8a219c703bc/ghc"
ba46e63f/ghc]:
{{{
#!CommitTicketReference repository="ghc"
revision="ba46e63f3d6f7d0438a0262f6711f8a219c703bc"
Fix #13948 by being pickier about when to suggest DataKinds
Commit 343cb32d0983f576d344a2d04a35c3fd6eecf2c5 (#13568) made GHC a bit
too cavalier in suggesting when data constructors are in scope (and
suggesting the use of `DataKinds`). This tones down the suggestions so
that `DataKinds` is only suggested if a data constructor of that name is
actually in scope (previously, it would always suggest, even if it was
out of scope).
Fixes #13948.
Test Plan: ./validate
Reviewers: mpickering, austin, bgamari
Reviewed By: mpickering
Subscribers: rwbarton, thomie
GHC Trac Issues: #13948
Differential Revision: https://phabricator.haskell.org/D3719
}}}
--
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/13948#comment:2>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler
More information about the ghc-tickets
mailing list