[GHC] #13311: Audit shady uses of tcSplitSigmaTy

GHC ghc-devs at haskell.org
Mon Jul 3 22:58:32 UTC 2017


#13311: Audit shady uses of tcSplitSigmaTy
-------------------------------------+-------------------------------------
        Reporter:  RyanGlScott       |                Owner:  RyanGlScott
            Type:  task              |               Status:  patch
        Priority:  normal            |            Milestone:  8.4.1
       Component:  Compiler (Type    |              Version:  8.1
  checker)                           |
      Resolution:                    |             Keywords:
Operating System:  Unknown/Multiple  |         Architecture:
                                     |  Unknown/Multiple
 Type of failure:  None/Unknown      |            Test Case:
      Blocked By:                    |             Blocking:
 Related Tickets:                    |  Differential Rev(s):  Phab:D3678
       Wiki Page:                    |
-------------------------------------+-------------------------------------

Comment (by Ben Gamari <ben@…>):

 In [changeset:"c3a78623cf7bb74c8ca0749f1216e802aa37a721/ghc" c3a7862/ghc]:
 {{{
 #!CommitTicketReference repository="ghc"
 revision="c3a78623cf7bb74c8ca0749f1216e802aa37a721"
 Fix #13311 by using tcSplitNestedSigmaTys in the right place

 Previously, we we only using `tcSplitSigmaTy` when determining if a
 function had been applied to too few arguments, so it wouldn't work for
 functions with nested `forall`s. Thankfully, this is easily fixed with a
 dash of `tcSplitNestedSigmaTys`.

 Test Plan: make test TEST=T13311

 Reviewers: austin, bgamari, simonpj

 Reviewed By: bgamari

 Subscribers: goldfire, simonpj, rwbarton, thomie

 GHC Trac Issues: #13311

 Differential Revision: https://phabricator.haskell.org/D3678
 }}}

--
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/13311#comment:7>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler


More information about the ghc-tickets mailing list