[GHC] #12559: Don't ignore addTopDecls in module finalizers

[GHC]

#12559: Don't ignore addTopDecls in module finalizers
-------------------------------------+-------------------------------------
        Reporter:                    |                Owner:
  facundo.dominguez                  |  facundo.dominguez
            Type:  bug               |               Status:  patch
        Priority:  normal            |            Milestone:  8.0.2
       Component:  Compiler          |              Version:  8.0.1
      Resolution:                    |             Keywords:  template-
                                     |  haskell
Operating System:  Unknown/Multiple  |         Architecture:
                                     |  Unknown/Multiple
 Type of failure:  None/Unknown      |            Test Case:
      Blocked By:                    |             Blocking:
 Related Tickets:  #11832            |  Differential Rev(s):  Phab:D2505
       Wiki Page:                    |
-------------------------------------+-------------------------------------

Comment (by Facundo Domínguez <facundo.dominguez@…>):

 In [changeset:"71dd6e4429833238bcdaf96da8e2e41a62dacbf4/ghc" 71dd6e4/ghc]:
 {{{
 #!CommitTicketReference repository="ghc"
 revision="71dd6e4429833238bcdaf96da8e2e41a62dacbf4"
 Don't ignore addTopDecls in module finalizers.

 Summary:
 Module finalizer could call addTopDecls, however, the declarations
 added in this fashion were ignored. This patch makes sure to rename,
 type check and incorporate this declarations.

 Because a declaration may include a splice which calls addModFinalizer,
 the list of finalizers is repeteadly checked after adding declarations
 until no more finalizers remain.

 Test Plan: ./validate

 Reviewers: bgamari, goldfire, simonpj, austin

 Reviewed By: bgamari, simonpj

 Subscribers: simonmar, mboes, thomie

 Differential Revision: https://phabricator.haskell.org/D2505

 GHC Trac Issues: #12559
 }}}

--
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/12559#comment:3>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler