[GHC] #12554: Testsuite exhibits large amount of framework failures
GHC
ghc-devs at haskell.org
Sun Oct 16 11:58:36 UTC 2016
#12554: Testsuite exhibits large amount of framework failures
-------------------------------------+-------------------------------------
Reporter: Phyx- | Owner:
Type: bug | Status: new
Priority: normal | Milestone:
Component: Test Suite | Version: 8.0.1
Resolution: | Keywords:
Operating System: Windows | Architecture:
Type of failure: Incorrect result | Unknown/Multiple
at runtime | Test Case:
Blocked By: | Blocking:
Related Tickets: | Differential Rev(s):
Wiki Page: |
-------------------------------------+-------------------------------------
Comment (by thomie):
Usage of `ignore_errors=True` was sloppy program, sorry about that.
It would be better to revert back to the original (working and commented)
code:
{{{
def clean_full_path(name):
try:
# Remove files...
os.remove(name)
except OSError as e1:
try:
# ... and empty directories
os.rmdir(name)
except OSError as e2:
# We don't want to fail here, but we do want to know
# what went wrong, so print out the exceptions.
# ENOENT isn't a problem, though, as we clean files
# that don't necessarily exist.
if e1.errno != errno.ENOENT:
print(e1)
if e2.errno != errno.ENOENT:
print(e2)
}}}
On the real bug: you could try to eliminate any possible problems with
`timeout`:
{{{
- r = subprocess.call([timeout_prog, timeout, cmd],
+ r = subprocess.call(['sh', '-c', cmd],
}}}
On Windows the testsuite uses a `timeout` program written in Haskell, on
all other platforms `timeout` is written in Python. I'm not quite sure why
two separate versions exist, but all the code is in `testsuite/timeout`.
Fwiw: I couldn't reproduce this issue myself, last time I tried.
--
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/12554#comment:15>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler
More information about the ghc-tickets
mailing list